OG Xbox, the One signaled the beginning downfall of the brand that the Series has continued (and possibly completed). Xbox One S was the first Xbox I ever owned, I bought it mostly to use as a 4K blu-ray player, and it was decent (I have a dedicated blu-ray player now though).
The controllers are pretty good, and they have genuinely amazing battery-life, I used mine on the PC for some time. During the One era, MS started turning their attention back to PC-gaming again, this was great for me as a primarily PC-gamer, but it did somewhat diminish the attraction of buying and owning an actual Xbox. Of course, this "broadening" of the brand via the One ecosystem and Gamepass has come into full play with the Series, and has taken its toll (heavily). Gamepass has turned out to be a blight on the brand, in my opinion, and has whipped up a highly undesirable model that others have since copied - in the long run this has caused issues for gamers and developers alike. The One was certainly more successful than the Series, but I see it as an overall loss to the OG Xbox, for the same reason the Series loses to it; opposite ends of a spectrum, where one was ambitious and positive, and the other defeatist and dark.
On a personal note, the Xbox One was part of the most boring generation of consoles I ever experienced. Along with the PS4, it created a market so steeped in sameness and complacency that it completely killed my interest in the console market overall, this has since lead into the very first generation where I don't own a single piece of console hardware for the current generation.