Switch Pro controller - despite its steep pricing. It has perfect ergonomics, great layout, and immense build-quality. The triggers are just deep enough, but not too deep (Xbox One controllers this issue for me). Nintendo released their worst and best controller on the same platform; by far the worst controller I used from them is the Joy-con (shallow, tiny buttons, weird layout, and insane pricing, and the infamous drift issues, an ergonomic and economic nightmare for me).

I actually liked the N64 controller as well, it's one of my all-time favorites, especially the "Z" button at the bottom, it was perfect for double-joystick controls in shooters and games like Rogue Squadron.

Switch 2 Pro Controller. It does everything the already superb Pro Controller does, but just a tad bit better. It also has the best analog sticks I have ever used. They just feel so damn smooth and precise. I'm always a little shocked when I play a little PS5, lol. I know drifting is an issue and I don't want to pretend it isn't. But I pesonally have never experienced it.

That said, just about any Nintendo Controller was awesome and there's nothing like playing the old games with the original controller. Which is why I got each and every one of them for Switch Online.

Switch 2 Pro Controller for general gaming as it's light and ergonomic but functionality wise the Switch 2 Joycons as they support pretty much everything.

Both the Pro Controller and the Pro Controller 2 have some of the biggest dogshit D-Pads I've seen in my life. Which is an insane thing to witness coming from Nintendo. That alone puts them weeeeell on the bottom.

My favourite controller ever is the Wii U Gamepad. Very comfortable to use, very ergonomic despite its size and it had plenty of useful features (off-tv play, maps and inventories on the fly, being able to check the browser or write notes while playing if you got stuck, integrated TV remote, headphone jack on a controller in 2012 was pretty novel...).

Never a controller has given me this much.

SNES standardized 4 face buttons and shoulder buttons.

Wavebird was ahead of it's time, via fantastic wireless with little lag.

Best overall, S2 Pro. First controller that is in competition with the xbox controller for my favorite in gaming. Feels great, love the buttons/layout and the mappable buttons on the back were great for Prime 4 (used them to pull up the map). I am very impressed with the S2 Pro controller.

People have nostalgia for the 360 controller but damn, that thing is nowhere near as good as modern gamepads. Gamepads have come a long way from being awkward and tacky. They don't feel like kids toys anymore.

S2 PC is the best. The GC controller is the most comfortable.

Oh, for sure. But if the results of this poll (and almost every other similar poll I've seen over the years) are any indication, recency bias is far more powerful.

Best overall: Switch 2 Pro Controller, with Switch Pro Controller slightly behind. Both have tons of functionality. It does suck that they still have digital triggers.
Best shape: GameCube Controller. Seriously comfy. Points for triggers and the weird button layout is pretty perfect for Smash.
Best battery life: Wii U Pro Controller. I never got one, but the battery is insane. About 80 hours or so.

I actually still really love the 360 pad myself, it's incredibly comfortable and the sticks/buttons/triggers feel good. D-Pad isn't great but most games barely use that so it's not a big deal, for me anyway.