It's hard for me to say, generally speaking I would say the 360 controller, but it has the crappiest D Pad EVER! so I guess that would be the highest up there, the PS3 controller is pretty good (if it had Rumble lol)...

I hate hate the 360 D-Pad but luckily not really many games need an accurate D-Pad anymore (which is why it doesn't affect my choice for top controller like lack of rumble or crappy shoulder buttons do). The only 360 game that has really upset over its D-Pad was Tetris Evolution and it just pissed me off in that game. I love Tetris, in fact, it easily fits in my top 3 games, but I hated Tetris Evolution because of the crap D-Pad, the rotate buttons were backwards from the DS version, and the fact you couldn't change the controls.

The dualshock and the 360 controller are by far the best ones ever, and for people who say a controller without two sticks are you crazy, try to play a game now without it, the second stick controls the camera now and shooters are just not able to run on old controllers. Go back and try to play goldeneye now with only one stick, its just terrible.

Oh please. If functionality were the only concern for 3d games, then Mouse+Keyboard would clearly be the winner. Dual Analogs are absolutely inferior. 

I like the ps2 controller. I do like the sixaxis (wireless, senors, lightweight) except the L2 and R2 buttons can be annoying; but it will be better with rumble, But being a Sony fan I am bias. So I gather the next one I like... would be the 360 -which feels good, though I'm not a fan of the analog stick at the top.

The ps3 choulder taps are not buttons, you dont press it its a push, it doesnt click that way its nearly impossible to get stuck.

The worst conroller is the gamecube controller I have a GC right now and if you compare it to the ps3 and n64 that I have the controller is all bulky and wierd. The oricginal xbox controllers werent that bad, but the wii controllers are awsome very nice and comfortable in you hand, the 360 controller is the same as the ps3 contoller but slightly heavier.

 Like I said, the Wii Remote seems to work very well for shooters.  It's very accurate (I can even be fairly accurate with the remote even in my right hand and I'm left handed though I usually don't play that way) and RE4 shows that.  I really think Metroid is going to build on the positive controls that RE4 started with and will actually have great FPS controls.

 For games like Call of Duty 3 and Red Steel, I heard those also had pretty good controls although they were bad games.  I didn't actually play either of those (got a free copy of Red Steel, never even bothered opening it) since they were supposed to be bad, but heard overall good things about the controls.

Another game that actually does a good job showing off how accurate the Wii Remote is Big Brain Academy: Wii Degree.  It is laser accurate in that game and you have to be moving fairly quick and be very accurate if you want any kind of decent score. 

I do like the Duelshock and 360 controller for their duel analogs but that's only because it's what we're so used to.  I remember picking up the Duelshock the first time and though it was a little wierd  having two analog stick but it was something I got use to after more games came out and took advantage of them.

So do you like point the Wiimote at the link or something, or use the nunchuck analogue stick, because that's the example I was using, becuase I find using a mouse more accurate than an analgoue stick. So if you're talking about using buttons then you've missed my point.

 I've actually had the least problems of all with my Duelshock and PS1 controllers.  I don't remember my N64 controllers breaking, but I know I've gone through 2 bad GC controllers (though I still love them) and one bad XBox controller.  I still have my original PS2 controllers that work fine and I even have my original PS1 controller that works fine (last I checked, it's been more than 2 years since I last used it).