Will have to wait a couple more months before I can say AstroBot has decent legs. It doesn't look like it'll beat Zelda in lifetime sales unless ported to Nintendo platforms.

It should beat Zelda once it gets a PC release

The question is I think this thread is asking about PS5 vs Switch sales, otherwise there will be then sales for the inevitable Switch 2 version of Zelda 

So far I'm leaning 80% in favour for Zelda winning in sales 

If you count an eventual PC release towards PS5 sales maybe. But it will sell better on PS5 overall, i think nobody should seriously doubt that. If you count PS5 and PC together... hmm... maybe it could outsell it. If Zelda gets a Switch 2 port, no chance in hell. But to be honest, we should except a AAA plattformer with PS5Pro Hype+ GOTY Award to outsell a 2D top down Zelda, heavily critisized by its fans. If you ad the fact that the plattform its running on will be replaced in some months it does not make things looking better for Astro...

Nobody said anything anywhere in this thread about Astro Bot coming close do Mario sales. Astro Bot wasn't advertised with the PS5 Pro, it's not a upgraded game. The Zelda reception wasn't as mixed as you're sugesting, it has a 8.4 user score on Metacritic.

Is a Switch 2 version of EoW inevitable? I think upgrades from BOTW and TOTK can happen, but even these are not guaranteed. I'm even less sure if they will make Switch 2 versions for the 2D Zeldas. 

But even without a Switch 2 SKU I think EoW will still sell more.

I don't see Astrobot getting a PC release in any near future. Not only is it not the kind of game to do especially well on PC, it's designed around the PS5 controller which I don't think is mandated for any PC releases. I just think it'll be last on any port list from Sony. I also don't think Zelda EOW Will get a Switch 2 port. More likely BOTW and TOTK if any 

After all these PC ports since 2019 everything is possible. But i also think before its getting a PC port, it will come to Switch 2!

But will Nintendo accept a game that is a giant Playstation/Sony advertisement?

Have you seen the switch eshop. They will accept anything 

I also think there is zero chance of Astro coming to Nintendo Platforms, that counters the whole branding of it being PlayStations flagship platformer designed around PS5 hardware. If anything lands on Nintendo it will be low value spinoffs (ala Lego Horizon) intending to bring people back to playstation or old PS4 era games. Astro is doing the exact job Sony intended it to do and is charting longer than games like Forbidden West, Ratchet Rift Apart etc so I don't think there is much grounding in any port talk for the time being.

"37% of the game's buyers are new users who haven't purchased a first-party title from PlayStation in two years."
https://hardcoregamer.com/astro-bot-sells-over-15-million-copies/

How many people swore that PS games will never go to PC? How many people where convinced that no first party IP will never come to rivalling plattforms? Yet we got Lego Horizon. If Nintendo released Lego Super Mario on PS and PC wouldn't hordes of Nintendo Haters shout: Nintendo goes 3rd Party? Nintendo is doomed? Astro has a better chance for a Switch 2 release than on PC! I'd give astro till late 2026 and we get a PC Port minimum! Sony is looking to maximize their profits. They don't care where you play the games if you play THEIR games and subscribe on THEIR services.