I pretty much never stopped using the gamecube controller. It have some flaws, but no other controller fits as nice in my hands. Bought versions of the controller for pretty much every gaming system. If no gamecube-like controller is present I use adapters. Currently using a wirless controller from PowerA with most functions of a pro controller but with the gamecube layout of buttons. My favorite controller so far.
Never got to buying a switch pro controller but used it a few times. Would probaly take the top spot for me if I get one. It just felt so premium to use.
The snes controller is still the best for retro gaming. The D-pad on the gamecube controller is awful and not comfortable to play with.
I hope the PS5 controller is great when I get my hands on that system. Skipped the PS4 and never really used that controller. Looks like the grip will rest better in my hand compared to the weak handles on the PS123 controllers.