I mentioned some of my thoughts on this during a thread about PlayStation controllers.
It's hard for me to say what is the absolute best. If nostalgia is a factor, I love the GameCube controller dearly. I never minded the flaws with it. It worked fine for virtually every GameCube and Wii game that supported it. It is still the best for Smash (but the Switch Pro Controller works really well).
My favorites (in no particular order): GameCube, Xbox 360, DualShock 4, Switch.
GameCube has a fantastic shape, and the unique face button design worked for the time. The triggers are super satisfying for most games.
Xbox 360 has a fantastic shape. Virtually the only flaw I can think of is the D-Pad.
DualShock 4 has the best triggers I've ever used to date, and I enjoy features like the speaker.
Switch Pro Controller is likely the best controller Nintendo's ever made. I wish there were analog triggers, though.
Lifetime Sales Predictions
Switch: 161 million (was 73 million, then 96 million, then 113 million, then 125 million, then 144 million, then 151 million, then 156 million)
PS5: 122 million (was 105 million, then 115 million) Xbox Series X/S: 38 million (was 60 million, then 67 million, then 57 million. then 48 million. then 40 million)
Switch 2: 120 million (was 116 million)
PS4: 120 mil (was 100 then 130 million, then 122 million) Xbox One: 51 mil (was 50 then 55 mil)
3DS: 75.5 mil (was 73, then 77 million)
"Let go your earthly tether, enter the void, empty and become wind." - Guru Laghima
