Warts and all, I think it is at minimum a good console.
Pros
+Got a lot of the third-party games PS4 got
+Xbox Live/Game Pass
+Backwards compatibility
+4K Blu-ray playback (on One S and One X), CD playback
+Kinect was at least something interesting, though it should not have been forced in the purchase like it was at the start.
+Xbox One X is a powerful console.
Cons
-Base console is weaker than a PS4
-Kinect made it more expensive at first
-Did not have the true and console exclusives desired by players that Xbox, Xbox 360, and PlayStation consoles have. It's not like it had none. People like Forza, Sea of Thieves and so on. It just doesn't have the caliber people expected from Xbox or Xbox's competitors.
Lifetime Sales Predictions
Switch: 159 million (was 73 million, then 96 million, then 113 million, then 125 million, then 144 million, then 151 million, then 156 million, then 161 million)
PS5: 116 million (was 105 million, then 115 million, then 122 million)
Xbox Series X/S: 38 million (was 60 million, then 67 million, then 57 million. then 48 million. then 40 million)
Switch 2: 120 million (was 116 million)
PS4: 120 mil (was 100 then 130 million, then 122 million) Xbox One: 51 mil (was 50 then 55 mil)
3DS: 75.5 mil (was 73, then 77 million)
"Let go your earthly tether, enter the void, empty and become wind." - Guru Laghima
