I have not used the Duke, or Series X/S controller.
I've only used the original S controller and Xbox One controllers a little bit.
I'm well aware the Xbox One controller has a better D-Pad than the Xbox 360 controller, but the little bit of time I've spent with the One's controller was a less comfortable shape than the 360. If I get more time with an Xbox One controller and some actual time with the Series controller, they will probably get my vote.
As is, the Xbox 360 controller is insanely comfortable, both official and unofficial wired versions or even typical versions with the battery pack.
Lifetime Sales Predictions
Switch: 161 million (was 73 million, then 96 million, then 113 million, then 125 million, then 144 million, then 151 million, then 156 million)
PS5: 115 million (was 105 million) Xbox Series S/X: 48 million (was 60 million, then 67 million, then 57 million)
PS4: 120 mil (was 100 then 130 million, then 122 million) Xbox One: 51 mil (was 50 then 55 mil)
3DS: 75.5 mil (was 73, then 77 million)
"Let go your earthly tether, enter the void, empty and become wind." - Guru Laghima