I personally feel that the best controller is the PS/PS2/PS3 controller. It hasn't changed much at all over the past 14 years and it doesn't need to. There is no other controller in the entire world that I could pick up and instantly feel like it was a part of me.
Of course if we start talking about FPS games then nothing beats the Keyboard/Mouse.