For instance, I still play with guitar hero III and Smash bros brawl and I have been playing them for years. Are there games that you still keep visiting after years and years? 

Played The Legend of Zelda a couple of weeks ago

Pikimin 2, Paper Mario: TTYD and Mario Kart: Double Dash for GC.

Zelda: TP, Mario Galaxy 1 & 2, DKCR and Smash Bros Brawl for Wii.

I have finished all of these several times, but they just fail to get old.

I actually play remakes like Ocarina of Time. I come back to Shen Mue I+II once in a year. For local multiplayer I power up older Nintendo consoles. Certain games like Final Fantasy VII, DKC 2 or Jet Force Gemini are always worth my time. But there is no game that I kept on playing continuously for more than a half year.

I have a top loading NES and 70 carts featuring every AAA title that system ever HAD. It stays plugged into the TV, and played regularly. Those games are now approaching 30 years old. Enough said.

I think I've played through Final Fantasy Tactics at least 5 times since it released on PS1.

It really is the best game ever made. Trying different party class compositions change the way to play the game every time.

I still play Dead Rising from time to time.

Yup. As far as recent games, I still play Super Mario Sunshine, Smash Bros Melee and Resident Evil Remake on the Wii (Gamecube emulation). I also keep it legal and have the roms to the cartridge games I have which are nearly every major Nintendo game for NES, SNES, and N64, so I play all those. I've completed the DKC games for SNES literally countless number of times (emulator and actual cartridge on SNES).

I replay Knights of the Old Republic II The Sith Lords at least yearly, since there is still content getting restored :D

I couldn't agree more.  Final Fantasy Tactics is, in my opinion, a masterpiece.  I've got three 'perfect' saves, or close to it, and have a few others where I've simply beaten the game.  I think the balance of game-play and the lure of learning new skills and getting new items is on the cusp of perfection.

Other than FFT, though, I don't play many games over.  I'll revisit Fallout 3/NV now and then, and I'll probably play Valkyria Chronicles again soon--though the reason I don't play the last one more is that the story breaks my heart.  I've beaten Borderlands and Borderlands 2 multiple times.  The same with Torchlight and Torchlight 2.

Now that I think about it, I love games where you're always progressing with new skills and gear, and you can select different play-styles.  Since I also love chess, games that require strategy are also high on my list.

Oh, and AudioSurf.  I play that one whenever I get new music.  It's still a blast.