My favorites are probably Xbox 360 controller, DS 2, Switch Pro, and N64. The latter is down to somehow fit my hands perfectly, the best trigger button of any controller I ever tried, and the multitude of functions it offered through its revolutionary expansion slot.
I use a 360 controller for the PC on the occasion that I blaspheme and actually use a controller, the Xbox One controller is too bulky and awkward (I do own two for my Xbox One S though).
Out of the 8th gen home consoles, none of the three came with satisfying standard controllers for me. The above mentioned Xbox One controller has major issues, the DS 4 is too elongated, the gimmicks kill me and the annoying lights that eat the batteries are stupid. The joy-con is simply unusable for me, with its small form, tiny buttons, and shallow triggers.