It's so difficult to answer this question. My favorite game ever in terms of how much I enjoyed it the first time I played it is definitely Ocarina of Time. My favorite game ever in terms of how much I have enjoyed it consistently over the years is probably Majora's Mask.
Honorable mentions to the first KOTOR, Paper Mario, Earthbound, and Streets of Rage 2.