In the end this is a question what you're used to. Nintendo fans think the Gamecube controller was the best, Sony fans will like the Dualshock the most, and both of our Xbox fans will prefer the Xbox controller. I might be something of an exception to my own rule, as I liked the Gamecube the most, but actually prefer the smaller Xbox controller.
Having a clear default pair of select and back in the form of A+B was probably the best thing about it. It annoyes me to no end how it's circle+cross with some PS2 games, triangle+circle with others etc. I honestly think all four last gen consoles had a horrible dpads, so that's a moot point.