Like all things in life... The answer to that question is... Depends.
Unless you only play in docked mode... And only if there is a must-have game, I would stick with the Switch OLED over the Switch 2, it's a better console.
With the Xbox One > Series X and Playstation 4 > Playstation 5.... That depends on the games you are playing.
In my games room I am still running the VCR model Xbox One, I opened up the console and replaced the internal mechanical HDD with a speedy Crucial SSD... And it's perfect for Minecraft, there would be minimal/zero benefit in replacing that console with an Xbox Series device... And that would apply to most eSports titles which had a respectful presentation and performance profile on Xbox One/Playstation 4.
In short, upgrade if you feel a need, rather than merely upgrading due to societal/peer pressures.

www.youtube.com/@Pemalite








