I own and love both, but DS wins, no contest.
DS had way more games, was cheaper, had better battery life, and more screen real estate. It was fully backwards compatible with GBA games. DS games were $30, while PSP games were $40-$50. You didn't need to buy a memory stick for your DS. The DS clamshell design meant you could put it in your pocket without scratching the screen.