RPGs have always been my favorite genre. Here are some of my favorites broken down by subgenre (and some are hard to classify).
Turn Based
Final Fantasy 7 is my favorite turned based RPG, and possibly my favorite RPG (depending on how you define RPG). I am also extremely fond of Final Fantasy 1, 4, 6, 9, 10, 11, and 12. I would put all of those games on my top 100 games of all time. I also really love Ultima 4 and have very fond memories of Wizardry. I also really love all of the old gold box D&D games, although I can't pick one out among the others. It wasn't the story that stuck with me so much as the gameplay. I also devoted about 1-2 years of my life mostly playing Neverwinter Nights (PC), because the fan community made a bunch of really fun adventures for it. Undertale is also a really fantastic game.
MMOs
Final Fantasy 11 is a game I played for years, and is my favorite MMO. However, I bought my own PC for the first time just to play Ultima Online.
Strategy RPGs
Final Fantasy Tactics is my favorite turn based SRPG, and I am also very fond of Final Fantasy Tactics Advance. Shining Force is also a great game along the same lines. My favorite Fire Emblem game is Fire Emblem: Path of Radiance. On the real-time side my favorite SRPG is Freedom Force and another amazingly excellent game is Valkyria Chronicles.
Roguelikes
My favorite pure roguelike is Shiren the Wanderer (DS), but I really liked Chocobo's Dungeon the Wii. A less traditional roguelike that I liked even more was FTL. Depending on how you define roguelike, I might as well put Diablo in there as well. (Odd that I've never played Diablo 2.) There is another game that I think of as a roguelike, but most probably think of it as an action RPG:
Action RPG
Dark Souls is an amazing RPG (although I think it is either a roguelike or a real-time RPG, but I guess action RPG is close enough). Kingdom Hearts 1 & 2 were extremely fun action RPGs. I also have had a ton of fun with Hyrule Warriors. And for that matter I believe the best action RPGs are actually the first three Zelda games: The Legend of Zelda, Zelda 2, and Link to the Past. My favorite game of all time is in fact The Legend of Zelda (NES).
There are a lot of other great RPGs out there, but well...I have to stop somewhere. 
curl-6 bet me that PS5 + X|S sales would reach 56m before year end 2023 and he was right.
My Bet With curl-6
My Threads:
Master Thread, Game of the Year/Decade
Switch Will Be #1 All Time
Zelda Will Outsell Mario (Achieved)
How Much Will MH Rise sell?
My Bet With Metallox







