I snatched up a PS4 Pro last year, to go along with my 4K TV. However, if I was given the choice between that and the Xbox One X...I'd probably still go with the PS4 Pro. With Microsoft's Xbox Play Anywhere policies, I can play many of the platform's biggest releases on my desktop, rendering a dedicated Xbox console seemingly as an afterthought. Sony, meanwhile, has no equivalent, and thus are forced to support their console with excellent exclusives. Plus, I will hopefully pick up a VR headset one of these days, and PSVR is still among the best bang for my buck in that arena.
This is a difficult question. If I already owned a regular PS4 (and thus had access to games like NieR: Automata, Persona 5, and Yakuza 0) then I would 100% upgrade to a Xbox One X rather than a PS4 Pro. My reasoning is that you'd get to enjoy the best of both worlds: all of the PS4 exclusives, and play multiplatform games on the more impressive (hardware-wise) console (plus the cool console-exclusive Xbox One games like Sunset Overdrive, PUBG, Dead Rising 3, etc.). Now, if someone owned no current-gen platforms, I'd recommend going with a PS4 Pro. The system works really well for multiplatform, and the third-party exclusives really tip the scales to its favor.
Zarmena Khan
Probably PS4 Pro. I have tiptoed around the idea of replacing my Xbox 360 with Xbox One but I just don't have it in me to fork out money for a console that has a library I'm not going to enjoy. I'm leaning towards the Switch, though.