Well...it has failed to inspire a purchase from me.
From a hobbyist perspective, it has failed to be particularly memorable, besides falling flat on its face at launch, MC Collection, and becoming PC-lite.
MS wanted it to sell 200m...considering it will be lucky to hit 60, that also seems like a fail.
Dunno about its profitability or how much damage its dealt to the Xbox brand, but it seems like MS laid a bad egg, knew they were stuck with it for some time, and have spent considerable resources in polish and adjusting its role for the company.