Button cramming with the GCN's controller? Come on, the Dual Shock has buttons under the sticks. UNDER THE STICKS PEOPLE!.
My favorite is the Wiimote. You can't go better than that. But my favorite "traditional" controller is the GCN's. It was absolutely ergonomic, it had precise sticks in the right place, the buttons where soft and friendly, plus it was wireless. The N64 was really good too, probably most precise stick ever... even it is the most fragile ever, too.