I didn't get a notification. Without digging through the code right now, I suspect that "edits" go through a different code-set, separate from the "new thread" and "quotereply" actions...Ã‚Â Ã‚Â ...and I'm conflicted as to whether I would want a notification to go out on edits, anyway.
On the one hand, I can see wanting to go back and add a mention to a previous post - but on the other, I could see it as an annoyance if you went back to correct spelling or punctuation in a post, and resent notifications to people from the original post.
Ah yeah, I can see why that could easily get annoying.
The reason I'm interested in that feature is because something I do a lot on this forum (just a few hours ago was the most recent) is that I make a post, and by the time I press Submit, I see someone else replied to me, or said something I want to reply to.
So my options are to post twice in a row (and I usually dont want to do that), wait a few minutes/hours until someone else posts again so that I can post, or I copy and paste their quote into my post and reply to them there, and hope they see it even though I know they won't get an alert.
So when you added the mention system, I thought that might solve my issue. But maybe there's something else that can be done to solve it.
Yeah, like I said - it's sort of a tricky situation. I ran into it myself, with this very thread!! I discovered after the fact (when Kirby mentioned he did not get an alert from my OP), that "new threads" were going through a different code-set and therefore, didn't have the latest code for properly processing "mentions". So, after I fixed the bug, I would have liked to have simply gone back to my original post and edit/submit in order to generate the alerts - but I knew it wouldn't work.
But maybe we SHOULD always generate mention alerts, even if you're editing a post that somebody has already been alerted to - you might be editing the context or adding additional points, and WANT the people who were originally mentioned, to get another alert to see your latest edits!!
Ugh - I'm honestly stuck on this one. I could just leave the onus on the poster and say: If you leave mentions in your edited post, those users will get another alert. If you DON'T want them to get another alert, then it's on YOU to remove those mentions before submitting your edit.
Edit: Screw it, I decided to implement on edits!! Let me know if you get notified @Hiku
Last edited by TalonMan - on 25 April 2019